Reimplement punch & address some unsigned underflow concerns.#53
Merged
Reimplement punch & address some unsigned underflow concerns.#53
Conversation
This was referenced Jul 26, 2025
Owner
Author
|
Unrelated in this PR: Changed default for insert_overlap recursive parameter to true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete remake of punch function, now respecting all interval types (closed, open, left_open, right_open, dynamic).
For example (all closed adjacent intervals) A punch of [0, 100] with tree [0, 25][50,90] will result in [26, 49][91,100] now, because [0,25][25,50] would share are border and both contain 25, which is not what punch is supposed to do. If it is supposed to do that, use open/regular closed intervals.
Punch with [-10,60]
Punch with [-10,60]